fix(appset): Fix AppSet Webhook for gitlab merge requests (#13766) #14319
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syst3m1cAn0maly
changed the title
Syst3m1cAn0maly
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14319 +/- ##
==========================================
- Coverage 49.88% 49.76% -0.13%
==========================================
Files 263 261 -2
Lines 45185 44676 -509
==========================================
- Hits 22541 22232 -309
+ Misses 20427 20257 -170
+ Partials 2217 2187 -30
☔ View full report in Codecov by Sentry. |
Syst3m1cAn0maly
force-pushed
the
bug-gitlab-pullrequest-webhook
branch
from
51d53ee to
511c5d9
Compare
Signed-off-by: Syst3m1An0maly <[email protected]>
Syst3m1cAn0maly
force-pushed
the
bug-gitlab-pullrequest-webhook
branch
from
511c5d9 to
7580dad
Compare
|
any update on this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes [#13766]
When using gitlab for the PullRequestGenerator, the webhook doesn't refresh the appset.
When I looked into the code, I noticed that the webhook for PullRequestGenerator for gitlab tries to match the project id with the name.
This fix changes the code so it correctly matches the path/name of the project with the path/name set up in the PullRequestGenerator.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.